PMD Results

The following document contains the results of PMD 5.0.5.

Files

org/settings4j/Constants.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 40
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 48

org/settings4j/connector/AbstractPropertyConnector.java

Violation Line
Return an empty array rather than null. 32–40

org/settings4j/connector/JNDIConnector.java

Violation Line
Possible God class (WMC=53, ATFD=19, TCC=0.007352941176470588) 17–376
Return an empty array rather than null. 102–123
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 206
debug logging that involves string concatenation should be guarded with isDebugEnabled() checks 244
This call to String.startsWith can be rewritten using String.charAt(0) 350

org/settings4j/contentresolver/ClasspathContentResolver.java

Violation Line
In J2EE, getClassLoader() might not work as expected. Use Thread.currentThread().getContextClassLoader() instead. 102
This call to String.startsWith can be rewritten using String.charAt(0) 112

org/settings4j/contentresolver/FSContentResolver.java

Violation Line
Return an empty array rather than null. 53–77
Avoid using final local variables, turn them into fields 87
This call to String.startsWith can be rewritten using String.charAt(0) 96
Avoid using Literals in Conditional Statements 99

org/settings4j/settings/SettingsManager.java

Violation Line
Avoid using Literals in Conditional Statements 88

org/settings4j/util/ExpressionLanguageUtil.java

Violation Line
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 45–54
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes. 56